Skip to content

Commit

Permalink
fix: Use correct bytecode in proxy error propagation check (#679)
Browse files Browse the repository at this point in the history
* fix: Use correct bytecode in proxy error propagation check

This was a mistake done when porting; the original code is correct.

* Add a changeset file
  • Loading branch information
Xanewok authored Sep 25, 2024
1 parent 1f0ae25 commit debac88
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/famous-eggs-buy.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@nomicfoundation/edr": patch
---

fix(tracing): Use correct subtrace when detecting error error propagation across delegatecall
2 changes: 1 addition & 1 deletion crates/edr_napi/src/trace/error_inferrer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1173,7 +1173,7 @@ impl ErrorInferrer {
_ => return Ok(false),
};

let inst = subtrace_bytecode.get_instruction(step.pc)?;
let inst = bytecode.get_instruction(step.pc)?;

// All the remaining locations should be valid, as they are part of the inline
// asm
Expand Down

0 comments on commit debac88

Please sign in to comment.