Add config validation for empty forking url

NomicFoundation · May 17, 2024 · e65ba6c · e65ba6c
1 parent c42b5c5
commit e65ba6c
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 0 deletions.
diff --git a/packages/hardhat-core/src/internal/core/config/config-validation.ts b/packages/hardhat-core/src/internal/core/config/config-validation.ts
@@ -401,6 +401,18 @@ export function getValidationErrors(config: any): string[] {
         );
       }
 
+      if (hardhatNetwork.forking !== undefined) {
+        if (isEmptyString(hardhatNetwork.forking.url)) {
+          errors.push(
+            getEmptyErrorMessage(
+              `HardhatConfig.networks.${HARDHAT_NETWORK_NAME}.forking.url`,
+              hardhatNetwork.forking.url,
+              "string"
+            )
+          );
+        }
+      }
+
       // Validating the accounts with io-ts leads to very confusing errors messages
       const { accounts, ...configExceptAccounts } = hardhatNetwork;
 

diff --git a/packages/hardhat-core/test/internal/core/config/config-validation.ts b/packages/hardhat-core/test/internal/core/config/config-validation.ts
@@ -857,6 +857,30 @@ describe("Config validation", function () {
             ERRORS.GENERAL.INVALID_CONFIG
           );
 
+          expectHardhatError(
+            () =>
+              validateConfig({
+                networks: {
+                  [HARDHAT_NETWORK_NAME]: {
+                    forking: { url: "" },
+                  },
+                },
+              }),
+            ERRORS.GENERAL.INVALID_CONFIG
+          );
+
+          expectHardhatError(
+            () =>
+              validateConfig({
+                networks: {
+                  [HARDHAT_NETWORK_NAME]: {
+                    forking: { url: " " },
+                  },
+                },
+              }),
+            ERRORS.GENERAL.INVALID_CONFIG
+          );
+
           expectHardhatError(
             () =>
               validateConfig({