Refactor compile cache #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcuadrado
reviewed
Jun 11, 2019
| filesExtension: string | ||
| ) { | ||
| const dates = await getModificationDatesInDir(dir, filesExtension); | ||
| const getMaxSourceDate = (sourceGlobalPaths: string[]) => |
There was a problem hiding this comment.
ResolvedFile already has a lastModificationDate field.
alcuadrado
reviewed
Jun 11, 2019
| ); | ||
| }; | ||
|
|
||
| const LAST_CONFIG_USED_FILENAME = "path-to-last-config-used.txt"; |
There was a problem hiding this comment.
Use solc config and Buidler version instead
alcuadrado
reviewed
Jun 11, 2019
| async (__, { run }) => run(TASK_BUILD_ARTIFACTS) | ||
| ); | ||
| task(TASK_COMPILE, "Compiles the entire project, building all artifacts") | ||
| .addFlag("f", "Force compilation ignoring cache") |
|
Let's use |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactor is fairly simple, we still use modification timestamps to check "change" in source files, but we now check library files (we get all the dependency source files from the
DependencyGraphobject).We know check for buidler's and solc's version, if they change, the cache is invalidated.
I've also simplified some of the code, using the observation that we just need to check the max date for source files against the min date of compiled artifacts (special casing the Buidler config file).
Feature
This pr includes a new
--forceflag to the builtincompiletask, to force compilation, disregarding cache.