Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement add params to OverridenTaskDefinition #488

Merged
merged 5 commits into from
Apr 4, 2020

Conversation

tmilar
Copy link
Contributor

@tmilar tmilar commented Mar 27, 2020

No description provided.

    * Adding a flag with the same name as an existing param
    in the same (or, a parent) task, will throw an error.
@tmilar tmilar marked this pull request as ready for review March 30, 2020 14:16
    * Also addParam() with isOptional = true, is now supported.
@tmilar tmilar force-pushed the add-params-overridden-task branch from a408312 to bea6c5b Compare March 30, 2020 14:30
Copy link
Member

@alcuadrado alcuadrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alcuadrado alcuadrado merged commit 199f332 into development Apr 4, 2020
@alcuadrado alcuadrado deleted the add-params-overridden-task branch April 4, 2020 20:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants