Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimension compatibility problems with JED #22

Closed
Exaxxion opened this issue Apr 9, 2021 · 0 comments · Fixed by #24
Closed

Dimension compatibility problems with JED #22

Exaxxion opened this issue Apr 9, 2021 · 0 comments · Fixed by #24
Labels
bug Something isn't working

Comments

@Exaxxion
Copy link

Exaxxion commented Apr 9, 2021

JED registers its dimensions extremely late in the loading process, which currently causes problems with our config loading and cake registration model. It isn't until the server is actually started that the dimensions appear, which is well after Forge registries have been locked.

For custom cakes, we currently guard against registering cakes for dimensions which are not reported as existing during the PreInitialization phase where mods load their configs. This is why we used to get those strange "119 is not a number" log spam in Omnifactory intermittently during initialization, and why we had to forcibly register our Void Cake with JEI.

I propose that in the interest of better supporting JED, we should move the check for whether a dimension exists from the Forge initialization lifecycle event handlers (where we load configs and register our items/blocks) to the Cake's onBlockActivated handler, which would have the effect of registering the cakes anyway and just preventing players from using them if the target dimension doesn't actually exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant