Address compatibility issues with JED dimensions #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Always register custom cakes even if the dimension doesn't exist during Forge mod initialization phase - Prevent the player from eating a placed custom cake if the target dimension does not exist, and log an error when this occurs
| if(!cache.containsKey(dim)) { | ||
| logger.error("No such dimension: \"{}\"", dim); | ||
| if(!isDimensionRegistered(dim)) { | ||
| logger.error("Requested dimension: \"{}\" does not exist. Please verify your configs.", dim); |
There was a problem hiding this comment.
Instead of just logging, a chat message should be displayed as well, because I imagine that most players will not have their log open while playing the game, and so will miss the logger warning, leaving them wondering why the cake is not working.
There was a problem hiding this comment.
Yeah, that's a fair point. I've reworked this such that the server thread will log an error and the client thread will print a message to the user in-game.
serenibyss
approved these changes
Apr 12, 2021
ALongStringOfNumbers
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22 by always registering configured custom cakes irrespective of whether the target dimension actually exists during FML initialization stages. Prevents players from actually eating the cake if the target dimension doesn't exist while the World is loaded, logging an error message to both the client and server that the configs need to be fixed.
It seems that a consequence of these changes is that existing Void Cakes (at least in my Omnifactory testing instance) disappeared from the world without warning. Perhaps it has something to do with actually registering the cake items properly rather than Omni's workaround of forcing JEI to list a cake with the expected NBT.
An extra benefit of this change is that now there's zero log spam about how Dim 119 doesn't exist during loading.