Implement workaround for fuel tooltip log spam bug #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #23; a proper fix needs to rework how we represent custom cakes.
Dimension validation only matters during teleport, no need for it here. Ensures that overlays will still show up for the cake.
ALongStringOfNumbers
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the log spam bug #23 with a workaround that updates
BlockCustomCake.cakeDimensionin the TOP/WAILA rendering methods (similar to what we do inonBlockActivated()) so it has a value set before the superclass implementation of those methods try to access it.In the longer term, a proper refactoring of custom cakes to avoid the state-swapping stuff is still desirable, so I don't want to link #23 and close it just yet.