Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/message sequence out of sync/2023 11 03 #588

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xaviergspintly
Copy link

Created a dispatch queue instead of Task for issue #586 . Tried provisioning 10 times and it succeeded.

@CLAassistant
Copy link

CLAassistant commented Nov 3, 2023

CLA assistant check
All committers have signed the CLA.

@philips77
Copy link
Member

Please rebase the PR.

@xaviergspintly xaviergspintly changed the base branch from issue-templates to main November 8, 2023 09:53
@xaviergspintly
Copy link
Author

Rebased wrt main.

@philips77
Copy link
Member

Why did you change to the queue only in 2 places, not in all sending methods?

I was actually planning to refactor all layers to be actor, so using Task would be mandatory. As I wrote in mentioned issue, I'll wait with merge but won't close the PR. You have a valid issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants