Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Echoreturn to required #258

Merged
merged 9 commits into from
Oct 11, 2019
Merged

Echoreturn to required #258

merged 9 commits into from
Oct 11, 2019

Conversation

halkver
Copy link
Contributor

@halkver halkver commented Oct 4, 2019

Fixes #231

nordicsemi/__main__.py Outdated Show resolved Hide resolved
nordicsemi/__main__.py Outdated Show resolved Hide resolved
nordicsemi/__main__.py Outdated Show resolved Hide resolved
nordicsemi/__main__.py Outdated Show resolved Hide resolved

if port is None and jlink_snr is not None:
port = get_port_by_snr(jlink_snr)

elif port is None:
port = enumerate_ports()
if port is None:
click.echo("\nNo Segger USB CDC ports found, please connect your board.")
return
raise click.UsageError("\nNo Segger USB CDC ports found, please connect your board.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a \n there?

nordicsemi/__main__.py Outdated Show resolved Hide resolved
nordicsemi/__main__.py Outdated Show resolved Hide resolved
nordicsemi/__main__.py Outdated Show resolved Hide resolved
@bihanssen bihanssen merged commit 074ed69 into master Oct 11, 2019
@bihanssen bihanssen deleted the echoreturn_to_required branch October 11, 2019 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors don't set a nonzero exit code
3 participants