Interface Metrics #468
Merged
Interface Metrics #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LionelJouin
added
kind/enhancement
LionelJouin
force-pushed
the
observability-intf
branch
2 times, most recently
from
3c4eee6
to
813b8f2
Compare
LionelJouin
force-pushed
the
observability-intf
branch
2 times, most recently
from
9d3f335
to
34277f2
Compare
LionelJouin
force-pushed
the
observability-intf
branch
2 times, most recently
from
6e0efab
to
b0e160a
Compare
zolug
reviewed
Nov 9, 2023
cmd/frontend/main.go
Outdated
| @@ -155,6 +159,47 @@ func main() { | |||
| // start watching events of interest via NSP | |||
| go watchConfig(ctx, cancel, c, fe) | |||
|
|
|||
| hostname, err := os.Hostname() | |||
There was a problem hiding this comment.
Would be better moving this to an earlier part of main()
zolug
approved these changes
Nov 9, 2023
Collect kernel rx_packets, tx_packets, rx_bytes, tx_bytes, rx_errors, tx_errors, rx_dropped, tx_dropped metrics of the interfaces Stateless-lb collects the metrics for the interfaces being created via NSM. A new chain element has been implemented to watch/unwatch interfaces based on their name. Frontend collects the metrics of the interface that is passed as environemnt variable.
LionelJouin
force-pushed
the
observability-intf
branch
from
b0e160a
to
aadd528
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Collect kernel rx_packets, tx_packets, rx_bytes, tx_bytes, rx_errors, tx_errors, rx_dropped, tx_dropped metrics of the interfaces Stateless-lb collects the metrics for the interfaces being created via NSM.
A new chain element has been implemented to watch/unwatch interfaces based on their name.
Frontend collects the metrics of the interface that is passed as environment variable.
Issue link
#428
#419
Checklist