Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAPA logs and other improvements #485

Merged
merged 3 commits into from
Dec 9, 2023
Merged

TAPA logs and other improvements #485

merged 3 commits into from
Dec 9, 2023

Conversation

zolug
Copy link
Collaborator

@zolug zolug commented Dec 5, 2023

Description

Improved logs to help troubleshooting (wrapped errors during return to help identify the error source during debugging etc.).

other improvements:
TAPA;

  • stream: Do not try to unregister target at target registry
    if stream has no identifier.
  • stream: During open when identifier collision is observed,
    release offending identifier by unregistering at target registry.
  • conduit: Compare VIPs received from configuration, and trigger
    NSM connection update upon change only.
  • conduit: Log connection monitor events related to control plane
    change and connection close for visibility.
  • conduit: Log when IPs of a NSM connection change. And initiate
    close and re-open of affected Streams through the stream manager.
  • Custom interfacename client chain element releases interface name
    during failed Request() when NSM connection was not established earlier.

stateless-lb;

  • Remove pending targets not part of the configuration (NSP) anymore.

Issue link

NA

Checklist

  • Purpose
    • Bug fix
    • New functionality
    • Documentation
    • Refactoring
    • CI
  • Test
    • [] Unit test
    • E2E Test
    • Tested manually
  • Introduce a breaking change
    • Yes (description required)
    • No

Custom interfacename client chain element releases
interface name during failed Request() when NSM
connection was not established before.
-stream: Do not try to unregister target at target registry
 if stream has no identifier
-stream: During open when identifier collision is observed,
 release offending identifier by unregistering at target registry.
-conduit: Compare VIPs received from configuration, and trigger
 NSM connection update upon change only.
-conduit: Log connection monitor events related to control plane
 change and connection close for visibility.
-conduit: Log when IPs of a NSM connection change. And initiate
 close and re-open of affected Streams through the stream manager.
@zolug zolug added kind/bug Something isn't working kind/enhancement New feature or request component/stateless-lb component/TAPA labels Dec 5, 2023
@zolug zolug merged commit 5f5079a into master Dec 9, 2023
13 checks passed
@zolug zolug deleted the tapa-improve branch August 13, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants