Uplift to nsm v1.13.2 #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LionelJouin
reviewed
Jul 16, 2024
zolug
force-pushed
the
nsm-sdk-uplift
branch
3 times, most recently
from
95b3f9c
to
c1d8fb4
Compare
LionelJouin
reviewed
Jul 18, 2024
Since nsm v1.13.2 the interface name generator no longer considers the connection ID. Thus, there was not much point keeping the random UUID prefix when creating the connection ID for proxy -> LB connection requests. From now on old connections are looked up using nsm monitor connection feature prior to requesting a connection to an LB.
LionelJouin
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uplift dependencies to nsm v1.13.2.
NSM interface name generator no longer relies on connection ID. Therefore, the proxy has been also modified by removing the random UUID prefix part from the connection ID used to request connections to stateless-lbs.
Issue link
Checklist