Skip to content

Commit

Permalink
Set M3M concurrency to 1 and add warning
Browse files Browse the repository at this point in the history
We currently have an issue with concurrency when associating a BMH to a
M3M. A mutex was already added before to the Associate function.
However, this does not completely solve the issue, because a caching
client is used. In other words, the next M3M to associate can sometimes
use cached data about the BMHs and pick one that is already associated.
  • Loading branch information
lentzi90 committed Jun 30, 2023
1 parent 18fd1b0 commit f7413ec
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -266,8 +266,8 @@ func initFlags(fs *pflag.FlagSet) {
"The address the health endpoint binds to.",
)

fs.IntVar(&metal3MachineConcurrency, "metal3machine-concurrency", 10,
"Number of metal3machines to process simultaneously")
fs.IntVar(&metal3MachineConcurrency, "metal3machine-concurrency", 1,
"Number of metal3machines to process simultaneously. WARNING! Currently not safe to set > 1.")

fs.IntVar(&metal3ClusterConcurrency, "metal3cluster-concurrency", 10,
"Number of metal3clusters to process simultaneously")
Expand Down

0 comments on commit f7413ec

Please sign in to comment.