Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't initiate new connections during a client shutdown (async API) #225

Merged
merged 6 commits into from
Aug 15, 2024
Merged

Don't initiate new connections during a client shutdown (async API) #225

merged 6 commits into from
Aug 15, 2024

Conversation

bjosv
Copy link
Collaborator

@bjosv bjosv commented Jun 10, 2024

  • No slot map updates during a client shutdown.
  • Don't follow redirects when a shutdown is requested to avoid reconnects or adding new nodes.
  • Don't accept new commands when the client is about to shutdown.

Fixes #222 and #219

@bjosv bjosv requested a review from zuiderkwast June 10, 2024 16:15
zuiderkwast
zuiderkwast reviewed Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I had these comments pending since before the vacation.

hircluster.c Outdated Show resolved Hide resolved
hircluster.c Outdated Show resolved Hide resolved
bjosv and others added 2 commits August 15, 2024 09:30
@bjosv @zuiderkwast
Update hircluster.c
a839ccb 
Co-authored-by: Viktor Söderqvist <[email protected]>
@bjosv @zuiderkwast
Update hircluster.c
857b9d3 
Co-authored-by: Viktor Söderqvist <[email protected]>
@bjosv bjosv merged commit 1efe528 into Nordix:master Aug 15, 2024
34 checks passed
@bjosv bjosv deleted the client-shutdown branch August 15, 2024 07:57
This was referenced Aug 15, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zuiderkwast zuiderkwast zuiderkwast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash while performing redisClusterAsyncFree()
2 participants
@bjosv @zuiderkwast