Skip to content

Commit

Permalink
[JENKINS-70169] Add comments explaining the absence of breadcrumb ite…
Browse files Browse the repository at this point in the history
…ms in `resources/hudson/PluginManager` (jenkinsci#7489)

* [JENKINS-70169] Add missing breadcrumb items in resources/hudson/PluginManager

* better no breadcrumb comment

* Replace breadcrumbs by a comment
  • Loading branch information
lemeurherve authored Jan 14, 2023
1 parent 40ac511 commit ea68bd8
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ THE SOFTWARE.
<j:set var="readOnlyMode" value="${!app.hasPermission(app.ADMINISTER)}"/>

<st:include page="sidepanel.jelly"/>
<!-- no need for additional breadcrumb here as the side panel offers enough functionality to browse between different pages -->

<l:main-panel>
<l:app-bar title="${%Advanced settings}"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ THE SOFTWARE.
<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:l="/lib/layout" xmlns:f="/lib/form">
<l:layout title="${%Available plugins} - ${%Plugin Manager}" permission="${app.SYSTEM_READ}">
<st:include page="sidepanel.jelly"/>
<!-- no need for additional breadcrumb here as the side panel offers enough functionality to browse between different pages -->

<l:main-panel>
<l:app-bar title="${%Plugins}" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ THE SOFTWARE.
<j:set var="readOnlyMode" value="${!app.hasPermission(app.ADMINISTER)}"/>

<st:include page="sidepanel.jelly"/>
<!-- no need for additional breadcrumb here as the side panel offers enough functionality to browse between different pages -->

<l:main-panel>
<l:app-bar title="${%Plugins}" />
Expand Down
1 change: 1 addition & 0 deletions core/src/main/resources/hudson/PluginManager/table.jelly
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ THE SOFTWARE.
</st:documentation>
<l:layout title="${%Updates} - ${%Plugin Manager}" permission="${app.SYSTEM_READ}">
<st:include page="sidepanel.jelly"/>
<!-- no need for additional breadcrumb here as we're on an "index" page already including breadcrumb -->

<l:main-panel>
<l:app-bar title="${%Plugins}" />
Expand Down

0 comments on commit ea68bd8

Please sign in to comment.