Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The list of all trackers is not loaded correctly #2171

Closed
the-lazy-fox opened this issue Apr 28, 2021 · 10 comments
Closed

The list of all trackers is not loaded correctly #2171

the-lazy-fox opened this issue Apr 28, 2021 · 10 comments

Comments

@the-lazy-fox
Copy link

Behaviour

Steps to reproduce this issue

  1. Open rutorrent with several torrents from several trackers
  2. Check the filter section "trackers"

Expected behaviour

All unique tracker should be in the list with a counter next to it + total volume summ

Actual behaviour

The list is empty and trackers will show up ONLY when I manually click on one torrent --> tracker added in the list but counter = 1
Then if I select another torrent it completed the filter section
Etc.

Configuration

  • Docker version (type docker --version) : Docker version 20.10.6, build 370c289
  • Docker compose version if applicable (type docker-compose --version) : docker-compose version 1.29.1, build c34c88b2
  • Platform (Debian 9, Ubuntu 18.04, ...) : Debian 10
  • System info (type uname -a) : Linux docker-host 4.19.0-16-amd64 Путь к лог-файлу #1 SMP Debian 4.19.181-1 (2021-03-19) x86_64 GNU/Linux

No issues in my client with 1000 and 2000 torrents.
I have this issue only for client with 4000+ torrents.

@Novik
Copy link
Owner

Novik commented Apr 29, 2021

ruTorrent (and xml-rpc api in common) is not intended for support such large number of torrents.
For 4000+ torrents you should use console or something like that.
Also you may check this - #2170 PR.

@Novik Novik closed this as completed Apr 29, 2021
@the-lazy-fox
Copy link
Author

Thanks for your feedback.
Any plan to integrate this PR ?
Best

@Novik
Copy link
Owner

Novik commented Apr 29, 2021

Sorry, but no (as minimum in the nearest future). Reasons:

  1. Problem already solved on the client level
  2. Too complex changes

@TrimmingFool
Copy link
Contributor

TrimmingFool commented Apr 29, 2021

ruTorrent (and xml-rpc api in common) is not intended for support such large number of torrents.
For 4000+ torrents you should use console or something like that.

With #2170 ruTorrent is running fine now for me even with ~3700 torrents. Especially with 'httprpc' enabled I don't see a problem to continue using ruTorrent 👍

@the-lazy-fox
Copy link
Author

Hello @TrimmingFool
Then it would be super great to integrate it somehow.
Otherwise, is there any other way?
Could we integrate the change in an "nightly" build to be able to test it at bigger stake?
Thanks

@TrimmingFool
Copy link
Contributor

@the-lazy-fox Novik is the maintainer/owner. For now you could use my fork: TrimmingFool@a42c506

@the-lazy-fox
Copy link
Author

the-lazy-fox commented Apr 29, 2021

Hello @Novik
What do you mean by "Problem already solved on the client level" ?
Regarding the "Too complex changes", as the changes are already done and in PR. We just need a part of the community to test them right?
Thanks!

@the-lazy-fox
Copy link
Author

the-lazy-fox commented May 6, 2021

Any updates?

@Novik
Copy link
Owner

Novik commented May 6, 2021

What do you mean by "Problem already solved on the client level" ?

Try to read PR description. "Size limitation is 16MiB on rtorrent master: rakshasa/rtorrent#905"

Regarding the "Too complex changes", as the changes are already done and in PR.

And, I think, a lot errors also was added by this PR. Who will support it?

We just need a part of the community to test them right?

You just need to update rtorrent from the master branch.
Or use corresponding fork of ruTorrent.

@TrimmingFool
Copy link
Contributor

Try to read PR description. "Size limitation is 16MiB on rtorrent master: rakshasa/rtorrent#905"

That's true if you assume that no one wants to use more than 8*3700=29600 torrents 😄

And, I think, a lot errors also was added by this PR. Who will support it?

I totally get that merging seems risky. All I know is that it fixed the issue on my rutorrent setup.
However, I have no real interest in "long term support" if you meant that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants