Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResolveNuGetPackageAssets allocates 3.7% of solution-wide design-time build #6755

Closed
nguerrera opened this issue Mar 30, 2018 · 6 comments
Closed

Comments

@nguerrera
Copy link

From @davkean on September 26, 2017 12:55

This is literally turning text -> text, can we do this without NewtonSoft.Json? Otherwise, try the lower level reader API that JSON.NET has?
image

Copied from original issue: dotnet/sdk#1605

@nguerrera
Copy link
Author

From @davkean on October 4, 2017 23:16

Some of this allocations is due to reading line annotations - turn that off via JsonLoadSettings.LineInfoHandling.

@nguerrera
Copy link
Author

This is the version of package resolution for non-SDK projects. cc @Pilchie Does this go in project-system or nuget?

@nguerrera
Copy link
Author

From @Pilchie on February 5, 2018 22:28

project-system has tended to make the changes, but the code lives at https://github.com/NuGet/NuGet.BuildTasks/.

@rohit21agrawal
Copy link
Contributor

my understanding was that the build tasks in NuGet.BuildTasks are actually owned by @Pilchie 's team, and not NuGet even though they live in our repository.

CC: @rrelyea

@nguerrera
Copy link
Author

Yes, I understood as much from #6755 (comment)

I also interpreted that as implying I should file the bug where the code lives, which is why I moved it here.

@nkolev92
Copy link
Member

Moved from: dotnet/NuGet.BuildTasks#81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants