handle the temp directory generation with under mono correctly #2691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivkan
approved these changes
Jan 23, 2019
nkolev92
requested review from
dtivel,
heng-liu,
PatoBeltran,
dominoFire and
jainaashish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#7793
One of the potential root causes to NuGet/Home#7341
Regression: No
Fix
Details:
There is a code path that potentially created a bad temp folder in the nuget.exe under mono scenario.
fyi @rrelyea
Testing/Validation
Tests Added: No
Reason for not adding tests: It's difficult to test this.
The existing tests should catch any other potential issues.
Validation: