Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move projects that target netcoreapp2.1 to netcoreapp3.1 #4402

Merged
merged 13 commits into from
Jan 28, 2022
Merged

Move projects that target netcoreapp2.1 to netcoreapp3.1 #4402

merged 13 commits into from
Jan 28, 2022

Conversation

nkolev92
Copy link
Member

@nkolev92 nkolev92 commented Jan 12, 2022 •
edited
Loading

Bug

Fixes: NuGet/Home#11502

Regression? Last working version:

Description

netcoreapp2.1 is EOL, we can move to netcoreapp3.1 given that we're using this framework only in test projects and the runnables (meaning, not libraries).

There's an issue that has to do with minimizing the frameworks we're targetting: NuGet/Home#9886, which can lead to speeding up our build.

Here's the current state of the frameworks:

  NuGet.CommandLine.FuncTest.csproj = net472
  NuGet.MSSigning.Extensions.FuncTest.csproj = net472
  NuGet.CommandLine.Test.csproj = net472
  NuGet.Indexing.Test.csproj = net472
  NuGet.MSSigning.Extensions.Test.csproj = net472
  NuGet.PackageManagement.UI.Test.csproj = net472
  NuGet.PackageManagement.VisualStudio.Test.csproj = net472
  NuGet.SolutionRestoreManager.Test.csproj = net472
  NuGet.Tools.Test.csproj = net472
  NuGet.VisualStudio.Common.Test.csproj = net472
  NuGet.VisualStudio.Implementation.Test.csproj = net472
  NuGet.VisualStudio.Internal.Contracts.Test.csproj = net472
  NuGet.VisualStudio.Test.csproj = net472
  NuGetConsole.Host.PowerShell.Test.csproj = net472
  Dotnet.Integration.Test.csproj = netcoreapp5.0
  Msbuild.Integration.Test.csproj = net472
  NuGet.Commands.FuncTest.csproj = net472;netcoreapp3.1;netcoreapp5.0
  NuGet.Packaging.FuncTest.csproj = net472;netcoreapp3.1;netcoreapp5.0
  NuGet.Protocol.FuncTest.csproj = net472;netcoreapp3.1;netcoreapp5.0
  NuGet.Signing.CrossFramework.Test.csproj = net472;netcoreapp5.0
  NuGet.XPlat.FuncTest.csproj = net472;netcoreapp3.1;netcoreapp5.0
  Microsoft.Build.NuGetSdkResolver.Test.csproj = net472;netcoreapp3.1;netcoreapp5.0
  NuGet.Build.Tasks.Console.Test.csproj = net472;netcoreapp3.1;netcoreapp5.0
  NuGet.Build.Tasks.Pack.Test.csproj = net472;netcoreapp3.1;netcoreapp5.0
  NuGet.Build.Tasks.Test.csproj = net472;netcoreapp3.1;netcoreapp5.0
  NuGet.CommandLine.Xplat.Tests.csproj = net472;netcoreapp3.1;netcoreapp5.0
  NuGet.Commands.Test.csproj = net472;netcoreapp3.1;netcoreapp5.0
  NuGet.Common.Test.csproj = net472;netcoreapp3.1
  NuGet.Configuration.Test.csproj = net472;netcoreapp3.1
  NuGet.Credentials.Test.csproj = net472
  NuGet.DependencyResolver.Core.Tests.csproj = net472;netcoreapp3.1;netcoreapp5.0
  NuGet.Frameworks.Test.csproj = net472;netcoreapp3.1
  NuGet.LibraryModel.Tests.csproj = net472;netcoreapp3.1
  NuGet.PackageManagement.Test.csproj = net472;netcoreapp3.1
  NuGet.Packaging.Test.csproj = net472;netcoreapp3.1;netcoreapp5.0
  NuGet.ProjectModel.Test.csproj = net472;netcoreapp3.1;netcoreapp5.0
  NuGet.Protocol.Tests.csproj = net472;netcoreapp3.1;netcoreapp5.0
  NuGet.Resolver.Test.csproj = net472;netcoreapp3.1;netcoreapp5.0
  NuGet.Shared.Tests.csproj = net472;netcoreapp3.1
  NuGet.Versioning.Test.csproj = net472;netcoreapp3.1
  API.Test.csproj = net472
  GenerateLicenseList.csproj = net5.0
  GenerateTestPackages.csproj = net472
  NuGet.StaFact.csproj = net472
  SampleCommandLineExtensions.csproj = net472
  TestableCredentialProvider.csproj = net472
  TestablePlugin.csproj = net472;netcoreapp3.1;netcoreapp5.0
  TestableVSCredentialProvider.csproj =
  Test.Utility.csproj = net472;netcoreapp3.1;netcoreapp5.0
  NuGet.CommandLine.csproj = net472
  NuGet.Console.csproj =
  NuGet.Indexing.csproj = net472
  NuGet.MSSigning.Extensions.csproj = net472
  NuGet.PackageManagement.PowerShellCmdlets.csproj =
  NuGet.PackageManagement.UI.csproj =
  NuGet.PackageManagement.VisualStudio.csproj =
  NuGet.SolutionRestoreManager.csproj =
  NuGet.Tools.csproj =
  NuGet.VisualStudio.Client.csproj =
  NuGet.VisualStudio.Common.csproj = net472
  NuGet.VisualStudio.Contracts.csproj = netstandard2.0
  NuGet.VisualStudio.Implementation.csproj = net472
  NuGet.VisualStudio.Internal.Contracts.csproj = net472
  NuGet.VisualStudio.Interop.csproj = net472
  NuGet.VisualStudio.OnlineEnvironment.Client.csproj =
  NuGet.VisualStudio.csproj = net472
  NuGetConsole.Host.PowerShell.csproj =
  Microsoft.Build.NuGetSdkResolver.csproj = net472;netstandard2.0;netcoreapp5.0
  NuGet.Build.Tasks.Console.csproj = net472;netcoreapp3.1;netcoreapp5.0
  NuGet.Build.Tasks.Pack.csproj = net472;netstandard2.0
  NuGet.Build.Tasks.csproj = net472;netstandard2.0;netcoreapp5.0
  NuGet.CommandLine.XPlat.csproj = net472;netcoreapp3.1;netcoreapp5.0
  NuGet.Commands.csproj = net472;netstandard2.0;netcoreapp5.0
  NuGet.Common.csproj = net472;netstandard2.0;net45
  NuGet.Configuration.csproj = net472;netstandard2.0;net45
  NuGet.Credentials.csproj = net472;netstandard2.0;netcoreapp5.0
  NuGet.DependencyResolver.Core.csproj = net472;netstandard2.0;netcoreapp5.0
  NuGet.Frameworks.csproj = net472;netstandard2.0;net40
  NuGet.LibraryModel.csproj = net472;netstandard2.0
  NuGet.Localization.csproj = netstandard2.0
  NuGet.PackageManagement.csproj = net472;netstandard2.0
  NuGet.Packaging.Core.csproj = net472;netstandard2.0;netcoreapp5.0
  NuGet.Packaging.Extraction.csproj = net45
  NuGet.Packaging.csproj = net472;netstandard2.0;netcoreapp5.0
  NuGet.ProjectModel.csproj = net472;netstandard2.0;netcoreapp5.0
  NuGet.Protocol.csproj = net472;netstandard2.0;netcoreapp5.0
  NuGet.Resolver.csproj = net472;netstandard2.0;netcoreapp5.0
  NuGet.Versioning.csproj = net472;netstandard2.0;net45
  NuGet.Console.TestContract.csproj = net472
  NuGet.OptProf.csproj = net472
  NuGet.PackageManagement.UI.TestContract.csproj = net472
  NuGet.Tests.Apex.csproj = net472

src projects:

  NuGet.CommandLine.csproj = net472
  NuGet.Console.csproj =
  NuGet.Indexing.csproj = net472
  NuGet.MSSigning.Extensions.csproj = net472
  NuGet.PackageManagement.PowerShellCmdlets.csproj =
  NuGet.PackageManagement.UI.csproj =
  NuGet.PackageManagement.VisualStudio.csproj =
  NuGet.SolutionRestoreManager.csproj =
  NuGet.Tools.csproj =
  NuGet.VisualStudio.Client.csproj =
  NuGet.VisualStudio.Common.csproj = net472
  NuGet.VisualStudio.Contracts.csproj = netstandard2.0
  NuGet.VisualStudio.Implementation.csproj = net472
  NuGet.VisualStudio.Internal.Contracts.csproj = net472
  NuGet.VisualStudio.Interop.csproj = net472
  NuGet.VisualStudio.OnlineEnvironment.Client.csproj =
  NuGet.VisualStudio.csproj = net472
  NuGetConsole.Host.PowerShell.csproj =
  Microsoft.Build.NuGetSdkResolver.csproj = net472;netstandard2.0;netcoreapp5.0
  NuGet.Build.Tasks.Console.csproj = net472;netcoreapp3.1;netcoreapp5.0
  NuGet.Build.Tasks.Pack.csproj = net472;netstandard2.0
  NuGet.Build.Tasks.csproj = net472;netstandard2.0;netcoreapp5.0
  NuGet.CommandLine.XPlat.csproj = net472;netcoreapp3.1;netcoreapp5.0
  NuGet.Commands.csproj = net472;netstandard2.0;netcoreapp5.0
  NuGet.Common.csproj = net472;netstandard2.0;net45
  NuGet.Configuration.csproj = net472;netstandard2.0;net45
  NuGet.Credentials.csproj = net472;netstandard2.0;netcoreapp5.0
  NuGet.DependencyResolver.Core.csproj = net472;netstandard2.0;netcoreapp5.0
  NuGet.Frameworks.csproj = net472;netstandard2.0;net40
  NuGet.LibraryModel.csproj = net472;netstandard2.0
  NuGet.Localization.csproj = netstandard2.0
  NuGet.PackageManagement.csproj = net472;netstandard2.0
  NuGet.Packaging.Core.csproj = net472;netstandard2.0;netcoreapp5.0
  NuGet.Packaging.Extraction.csproj = net45
  NuGet.Packaging.csproj = net472;netstandard2.0;netcoreapp5.0
  NuGet.ProjectModel.csproj = net472;netstandard2.0;netcoreapp5.0
  NuGet.Protocol.csproj = net472;netstandard2.0;netcoreapp5.0
  NuGet.Resolver.csproj = net472;netstandard2.0;netcoreapp5.0
  NuGet.Versioning.csproj = net472;netstandard2.0;net45

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A

  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@nkolev92 nkolev92 requested a review from a team as a code owner January 12, 2022 02:17
@nkolev92 nkolev92 changed the title Move the test framework from netcoreapp2.1 to netcoreapp3.1 Move projects that target netcoreapp2.1 to netcoreapp3.1 Jan 12, 2022
@nkolev92 nkolev92 force-pushed the dev-nkolev92-bumpTestFrameworks branch from 02d0603 to eb27037 Compare January 13, 2022 02:44
@nkolev92 nkolev92 force-pushed the dev-nkolev92-bumpTestFrameworks branch from f403657 to 4593cd4 Compare January 19, 2022 01:55
@nkolev92
Copy link
Member Author

Linux tests are timing out unfortunately.

Unclear the problem is. I might need some tools about detetcting long running, but I won't have the bandwidth until QW so gonna pause on this until then.

I don't expect a re-review to be necessary here.

@nkolev92 nkolev92 force-pushed the dev-nkolev92-bumpTestFrameworks branch from 67379fb to e6bdaea Compare January 22, 2022 00:17
@nkolev92 nkolev92 force-pushed the dev-nkolev92-bumpTestFrameworks branch from e6bdaea to 4b9f831 Compare January 27, 2022 19:02
@nkolev92 nkolev92 merged commit d619bad into dev Jan 28, 2022
@nkolev92 nkolev92 deleted the dev-nkolev92-bumpTestFrameworks branch January 28, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffkl jeffkl jeffkl approved these changes

@erdembayar erdembayar erdembayar approved these changes

@zivkan zivkan zivkan approved these changes

@dominoFire dominoFire Awaiting requested review from dominoFire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move NuGet test projects from netcoreapp2.1 to netcoreap3.1
5 participants
@nkolev92 @dominoFire @zivkan @erdembayar @jeffkl