PrivateAssets for central transitive dependencies should flow regardless whether the parent node is a project or a package #4952
Conversation
…rcink-20221128-assets_flow_for_project_and_packages
…ess whether the parent is a project or a package
ghost
added
the
marcin-krystianc
changed the title
|
Next one is #4953 |
|
Does this also solve NuGet/Home#10907 by any chance? (non CPM scenarios) |
…rcink-20221128-assets_flow_for_project_and_packages
…s_flow_for_project_and_packages
No, very unlikely. The only significant change here is in the |
…s_flow_for_project_and_packages
| { | ||
| LibraryDependency parentDependency = targetFrameworkInformation.Dependencies.FirstOrDefault(i => i.Name.Equals(parentNode.Item.Key.Name, StringComparison.OrdinalIgnoreCase)); |
There was a problem hiding this comment.
targetFrameworkInformation.Dependencies doesn't contain projects.
|
@marcin-krystianc it looks like some unit tests are failing, please take a look. |
Apologies for that, it is fixed now. |
No apology necessary, just wanted to make sure you were aware! |
| LibraryDependency parentDependency = rootNode.Item.Data.Dependencies.FirstOrDefault(i => i.Name.Equals(parentNode.Item.Key.Name, StringComparison.OrdinalIgnoreCase)); | ||
|
|
||
| // A transitive dependency that is a few levels deep won't be a top-level dependency so skip it | ||
| if (parentDependency == null || parentDependency.ReferenceType != LibraryDependencyReferenceType.Direct) |
There was a problem hiding this comment.
This extra check is necessary, because rootNode.Item.Data.Dependencies contains also centrally managed transitive references which should be ignored here.
Thanks for the heads up, I've simplified the test code a little bit, |
marcin-krystianc
requested review from
nkolev92 and
jeffkl
and removed request for
nkolev92
marcin-krystianc
deleted the
marcink-20221128-assets_flow_for_project_and_packages
branch
Bug
Fixes: NuGet/Home#12276
Regression? Last working version: no
Description
When we check whether a node directly belongs to a root node, we need to look at
rootNode.Item.Data.Dependenciesinstead oftargetFrameworkInformation.Dependencies. The former contains projects, but the latter does not.PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation