Remove missing project references in static graph-based restore #5068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
changed the title
nkolev92
reviewed
Feb 28, 2023
test/NuGet.Core.FuncTests/Msbuild.Integration.Test/MsbuildRestoreTaskTests.cs
Outdated
Show resolved
Hide resolved
nkolev92
previously approved these changes
Feb 28, 2023
jeffkl
commented
Feb 28, 2023
src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/MSBuildRestoreUtility.cs
Show resolved
Hide resolved
aortiz-msft
previously approved these changes
Feb 28, 2023
nkolev92
previously approved these changes
Feb 28, 2023
jeffkl
force-pushed
the
dev-jeffkl-ignore-missing-project-references
branch
from
5e3a838
to
f341bf2
Compare
zivkan
reviewed
Mar 1, 2023
src/NuGet.Clients/NuGet.PackageManagement.UI/Models/PackageDetailControlModel.cs
Outdated
Show resolved
Hide resolved
jeffkl
force-pushed
the
dev-jeffkl-ignore-missing-project-references
branch
from
f341bf2
to
969926b
Compare
jeffkl
force-pushed
the
dev-jeffkl-ignore-missing-project-references
branch
from
969926b
to
60dfa6d
Compare
zivkan
approved these changes
Mar 2, 2023
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12322
Regression? Last working version:
Description
Static graph-based restore will leave project references for projects that don't actually exist in the graph. Regular restore manually removes any projects that don't support restore so this update just adds a call to the existing method. In performance testing, this added very little overhead.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation