Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project restore when CentralPackageVersionOverrideEnabled=false #5103

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

kant2002
Copy link
Contributor

@kant2002 kant2002 commented Mar 21, 2023

This is fix restoring of the project under CPM. If adding <CentralPackageVersionOverrideEnabled>false</CentralPackageVersionOverrideEnabled> to clean project then dotnet restore fails to work.

Bug

Fixes: NuGet/Home#12500

Regression? Last working version:

Description

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A
  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

This is fix restoring of the project under CPM. If adding
`<CentralPackageVersionOverrideEnabled>false</CentralPackageVersionOverrideEnabled>` to clean project then `dotnet restore` fails to work.
@kant2002 kant2002 requested a review from a team as a code owner March 21, 2023 06:13
@ghost ghost added the Community PRs created by someone not in the NuGet team label Mar 21, 2023
@kant2002
Copy link
Contributor Author

/cc @Ilchert which discover this issue originally.

@jeffkl jeffkl self-assigned this Mar 21, 2023
Copy link
Contributor

@jeffkl jeffkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your contribution is greatly appreciated!

@jeffkl
Copy link
Contributor

jeffkl commented Mar 21, 2023

@nkolev92 can I get a merge? The only failing test is flaky.

@nkolev92 nkolev92 merged commit 3066287 into NuGet:dev Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PRs created by someone not in the NuGet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set CentralPackageVersionOverrideEnabled=false in project with CPM broke project restore
3 participants