Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Newtonsoft.Json from 13.0.1 to 13.0.3 #5385

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

mthalman
Copy link
Contributor

@mthalman mthalman commented Aug 29, 2023

Bug

Fixes: NuGet/Home#12858

Regression? Last working version:

Description

.NET repos currently have a mix of Newtonsoft.Json versions that we're trying to get consolidated into the latest version. This is particularly necessary for the .NET's source-build which can only reference one version of a dependency.

Related to dotnet/source-build-externals#195

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A
  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@mthalman mthalman requested a review from a team as a code owner August 29, 2023 13:27
@ghost ghost added the Community PRs created by someone not in the NuGet team label Aug 29, 2023
@mthalman
Copy link
Contributor Author

cc @MichaelSimons for review

Copy link
Member

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mthalman

Thanks for the PR.
Please follow the PR template. We depend on that for automation. For product changes like this, we need a NuGet/Home tracking issue as per the template.

I don't think we need to change the test code either. Those tests are not run in source build scenarios anyways.

test/EndToEnd/tests/BuildIntegratedTest.ps1 Outdated Show resolved Hide resolved
Copy link
Member

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. Our insertions are blocked today, so not sure if this would stand a chance at making P2 in VS.

The SDK seems to be using 13.0.1. https://github.com/dotnet/sdk/blob/main/eng/Versions.props#L31.
Do we need to coordinate with them?

@mthalman
Copy link
Contributor Author

The SDK seems to be using 13.0.1. https://github.com/dotnet/sdk/blob/main/eng/Versions.props#L31.

Yes, I've got a PR for the SDK changes: dotnet/sdk#35008

Back-references for all PRs related to this work can be found at dotnet/source-build-externals#195.

@zivkan zivkan merged commit 9e17be6 into NuGet:dev Aug 31, 2023
1 check passed
@mthalman mthalman deleted the newtonsoft-json branch August 31, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PRs created by someone not in the NuGet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Newtonsoft.Json reference to 13.0.3
5 participants