-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Newtonsoft.Json from 13.0.1 to 13.0.3 #5385
Conversation
cc @MichaelSimons for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mthalman
Thanks for the PR.
Please follow the PR template. We depend on that for automation. For product changes like this, we need a NuGet/Home tracking issue as per the template.
I don't think we need to change the test code either. Those tests are not run in source build scenarios anyways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good. Our insertions are blocked today, so not sure if this would stand a chance at making P2 in VS.
The SDK seems to be using 13.0.1. https://github.com/dotnet/sdk/blob/main/eng/Versions.props#L31.
Do we need to coordinate with them?
Yes, I've got a PR for the SDK changes: dotnet/sdk#35008 Back-references for all PRs related to this work can be found at dotnet/source-build-externals#195. |
Bug
Fixes: NuGet/Home#12858
Regression? Last working version:
Description
.NET repos currently have a mix of Newtonsoft.Json versions that we're trying to get consolidated into the latest version. This is particularly necessary for the .NET's source-build which can only reference one version of a dependency.
Related to dotnet/source-build-externals#195
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation