Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow HTTPS sources that have SSL certificate problems #5674

Merged
merged 5 commits into from
Apr 4, 2024

Conversation

Nigusu-Allehu
Copy link
Contributor

@Nigusu-Allehu Nigusu-Allehu commented Mar 8, 2024

Bug

Fixes: NuGet/Home#4387

Regression? Last working version:

Description

This PR is merging a feature branch that:

PR Checklist

@Nigusu-Allehu Nigusu-Allehu requested a review from a team as a code owner March 8, 2024 04:06
@Nigusu-Allehu Nigusu-Allehu changed the title Dev feature disable tls certificate verification Restore from HTTPS sources that have SSL certificate problems Mar 8, 2024
@Nigusu-Allehu Nigusu-Allehu force-pushed the dev-feature-disable-TLS-certificate-verification branch from 2baabcf to ea7fea2 Compare March 8, 2024 04:19
@nkolev92
Copy link
Member

nkolev92 commented Mar 8, 2024

Let's hold this for 6.11, we're in P3, so we're feature complete already.

@Nigusu-Allehu Nigusu-Allehu force-pushed the dev-feature-disable-TLS-certificate-verification branch from 0d59bf8 to 1819d4e Compare March 8, 2024 21:16
@jeffkl jeffkl added the Merge next release PRs that should not be merged until the dev branch targets the next release label Mar 8, 2024
@Nigusu-Allehu Nigusu-Allehu marked this pull request as draft March 12, 2024 20:14
@dotnet-policy-service dotnet-policy-service bot added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Mar 20, 2024
@Nigusu-Allehu Nigusu-Allehu self-assigned this Mar 22, 2024
@dotnet-policy-service dotnet-policy-service bot removed the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Mar 22, 2024
@Nigusu-Allehu Nigusu-Allehu marked this pull request as ready for review April 1, 2024 19:15
@Nigusu-Allehu Nigusu-Allehu force-pushed the dev-feature-disable-TLS-certificate-verification branch from 666889d to 44921e0 Compare April 1, 2024 20:09
@Nigusu-Allehu Nigusu-Allehu removed the Merge next release PRs that should not be merged until the dev branch targets the next release label Apr 1, 2024
@Nigusu-Allehu Nigusu-Allehu changed the title Restore from HTTPS sources that have SSL certificate problems Allow HTTPS sources that have SSL certificate problems Apr 1, 2024
@Nigusu-Allehu Nigusu-Allehu merged commit ca13cf0 into dev Apr 4, 2024
12 of 16 checks passed
@Nigusu-Allehu Nigusu-Allehu deleted the dev-feature-disable-TLS-certificate-verification branch April 4, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NuGet cannot restore from HTTPS sources that have SSL certificate problems
4 participants