This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Update jobs to use NuGet.Services.Logging 2.1.1 #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtivel
requested review from
joelverhagen,
agr,
xavierdecoster,
shishirx34,
ryuyu,
chenriksson,
cristinamanum,
skofman1 and
scottbommarito
scottbommarito
approved these changes
Apr 5, 2017
joelverhagen
reviewed
Apr 5, 2017
| @@ -48,8 +48,8 @@ | |||
| <Reference Include="Newtonsoft.Json, Version=9.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL"> | |||
| <HintPath>..\..\packages\Newtonsoft.Json.9.0.1\lib\net45\Newtonsoft.Json.dll</HintPath> | |||
| </Reference> | |||
| <Reference Include="NuGet.Services.Logging, Version=2.1.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL"> | |||
| <HintPath>..\..\packages\NuGet.Services.Logging.2.1.0\lib\net452\NuGet.Services.Logging.dll</HintPath> | |||
| <Reference Include="NuGet.Services.Logging, Version=2.1.1.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL"> | |||
There was a problem hiding this comment.
We talked about two things a while back to release a new (stable) .nupkg:
- Quality is verified by the .nupkg's own CI as well as a verification of the consumer on
dev. Has this been done for these jobs? - Stable version is pinned in MyGet.
Has these been done?
There was a problem hiding this comment.
(previously we had talked about NuGetGallery.Core, and verification with Gallery functional tests, but the analogy here is manually verification of the jobs)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue NuGet/NuGetGallery#3739.