This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
When SemVer 2.0.0 registration is disabled, put SemVer 2.0.0 packages in legacy registration #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in legacy registration
xavierdecoster
approved these changes
Apr 5, 2017
scottbommarito
approved these changes
Apr 5, 2017
| // Verify the contents of the SemVer 1.0.0 storage | ||
| var legacyCursor = _legacyStorage.Content.FirstOrDefault(pair => pair.Key.PathAndQuery.EndsWith("cursor.json")); | ||
| Assert.NotNull(legacyCursor.Key); | ||
| var legacyIndex = _legacyStorage.Content.FirstOrDefault(pair => pair.Key.PathAndQuery.EndsWith("/testpackage.semver2/index.json")); |
There was a problem hiding this comment.
check for existence of the leaf node as well just in case?
There was a problem hiding this comment.
Yup, good idea. This is already implied by the cursor NotNull assertion and the count equaling 1 assertion. But it's best to be explicit here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only necessary because of NuGet/NuGetGallery#3737. If one of these packages is edited (metadata edit or unlist), we should not ignore the catalog entry's effect on the existing registration hives (original and gzipped).