Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hit the database for retrieving packages #2527

Closed
maartenba opened this issue Jun 3, 2015 · 7 comments
Closed

Don't hit the database for retrieving packages #2527

maartenba opened this issue Jun 3, 2015 · 7 comments
Assignees

Comments

@maartenba
Copy link
Contributor

Following on #2522 and inconsistency between DB / search, we should update the gallery and make sure no pages / services hit the database directly. Some front-ends to look at:

  • Package details page
  • OData: find packages by id
  • OData: find updates

Once finished, revert #2522 in a meaningful way (e.g. owners may want to look at pending packages still)

@yishaigalatzer
Copy link

For the first item - The goal here is that once search service updates go in, the search service will no longer show packages that haven't been indexed. The plan is to make the website get the list of unindexed packages (from the catalog) and show them as pending.

@johnataylor
Copy link
Member

It's very difficult for the web site to read the catalog directly. The data in the catalog has to be processed first by some job.

The index is the mechanism by which the web site gets the package data from the catalog.

The indexing processes also provide some parts of the index in a slightly optimized way such that clients can sometimes by-pass a computed lookup in Lucene. The web site could read that, that would be harmless, though also pointless. The point is reading the catalog directly is tricky and that's by design.

@maartenba maartenba added this to the S2 milestone Jun 18, 2015
@maartenba maartenba self-assigned this Jun 18, 2015
@maartenba
Copy link
Contributor Author

Fixed OData feed with #2550
Package details page pending.

@yishaigalatzer yishaigalatzer modified the milestones: S2, S3 Jun 22, 2015
xavierdecoster added a commit that referenced this issue Jun 23, 2015
Don't hit the database for retrieving packages #2527
@maartenba
Copy link
Contributor Author

Ran stress test, will need to be revisited because perf was lower than hitting the database. This does mean we still have the possible inconsitency for now, but this is not ready for prime time.

@maartenba
Copy link
Contributor Author

@yishaigalatzer During triage, please move this one to a future sprint. We'll need to work on perf in search before we revisit this one.

@maartenba
Copy link
Contributor Author

The feed optimization is now part of #2583. It uses raw search and is now lightning fast.
Package details page in gallery still hits the database.

@maartenba maartenba modified the milestones: S3, S4 Aug 18, 2015
@maartenba maartenba self-assigned this Oct 9, 2015
@maartenba
Copy link
Contributor Author

Fixed with #2821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants