Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

many nugets are currently showing "This package has not been indexed yet" #3006

Closed
maartenba opened this issue Apr 28, 2016 · 8 comments
Closed
Assignees

Comments

@maartenba
Copy link
Contributor

From @SimonCropp on August 4, 2015 23:5

even though they were deployed a long time ago

https://www.nuget.org/packages/EntityFramework/5.0.0
https://www.nuget.org/packages/Fody/1.29.0
https://www.nuget.org/packages/Newtonsoft.Json/3.5.8

Copied from original issue: NuGet/Home#1112

@maartenba maartenba self-assigned this Apr 28, 2016
@maartenba
Copy link
Contributor Author

From @yishaigalatzer on August 5, 2015 17:27

@SimonCropp thanks for the report. We are aware and actively looking at

  1. Updating our monitoring to catch the issues
  2. Fix the individual packages
  3. Track the bug causing this

CC @johnataylor @maartenba @xavierdecoster @bhuvak

@maartenba
Copy link
Contributor Author

From @yishaigalatzer on August 6, 2015 1:28

This looks like is just a bug in the notification, for packages that are not the latest package. We are looking into a solution. Thanks for reporting

@maartenba
Copy link
Contributor Author

From @SimonCropp on August 6, 2015 1:30

BTW a google search for "This package has not been indexed yet" will show u more examples

@maartenba
Copy link
Contributor Author

From @johnataylor on August 6, 2015 1:30

I think the “not indexed yet” banner is giving us some false negatives. i.e. its saying that packages are not yet indexed when in fact they are.

The fix is in this code I think: (PackagesController.cs l.304)

        if (_searchService.ContainsAllVersions)
        {
            var isIndexedCacheKey = string.Format("IsIndexed_{0}_{1}", package.PackageRegistration.Id, package.Version);
            var isIndexed = HttpContext.Cache.Get(isIndexedCacheKey) as bool?;
            if (!isIndexed.HasValue)
            {
                var searchFilter = SearchAdaptor.GetSearchFilter(
                        "id:\"" + package.PackageRegistration.Id + "\" AND version:\"" + package.Version + "\"",
                        1, null, SearchFilter.ODataSearchContext);
                var results = await _searchService.RawSearch(searchFilter);

That is to say you are building a raw Lucene query and need to say that. This also avoids the filtering logic too I think.

Anyhow, without this many packages (everything but the latest?) are appearing as “not indexed” when in fact they are.

@maartenba
Copy link
Contributor Author

A fix has been deployed.

@maartenba
Copy link
Contributor Author

From @ryanhelms on April 28, 2016 6:13

Has this bug be reintroduced? I am getting the "This package has not been indexed yet" banner on many packages, example:

And after just searching around for a few, I noticed that there are a lot (90% of the non-latest package) being reported "not been indexed yet", example:

_(3 randomly selected packages, not latest stable package)_

@maartenba
Copy link
Contributor Author

Looking into it, thanks!

@maartenba
Copy link
Contributor Author

Issue resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant