Fix for issue #1844 - Email sent when removing package owner #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AlexBHarley, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
| _packageService.RemovePackageOwner(package, user); | ||
|
|
||
| var currentUser = _userService.FindByUsername(HttpContext.User.Identity.Name); | ||
| _messageService.SendPackageOwnerRemovedNotice(currentUser, user, package); |
There was a problem hiding this comment.
You may want to check currentUser for null
|
Looks good! Added a few remarks. Also can you try squashing your commits into one? |
AlexBHarley
force-pushed
the
email-sent-to-package-owner-when-removed-alexbharley
branch
from
59a4f77
to
42a2e20
Compare
|
Fixed those few things - not sure if my check for null is correct. And squashed into a single commit. |
maartenba
added a commit
that referenced
this pull request
Feb 10, 2016
…-when-removed-alexbharley Fix for issue #1844 - Email sent when removing package owner
|
Awesome! Good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1844 by sending an email to the package owner when being removed from a package.
I have taken some liberties as I wasn't sure how to phrase the message - feedback on the code and the message would be much appreciated.