Propagate correlation id from gallery to search service #2892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @skofman1, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
@maartenba, @xavierdecoster , is this ok to submit? |
|
@skofman1, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
| @@ -169,8 +174,8 @@ public IHttpActionResult GetPropertyFromPackages(string propertyName, string id, | |||
| { | |||
| switch (propertyName.ToLowerInvariant()) | |||
| { | |||
| case "id": return Ok(id); | |||
| case "version": return Ok(version); | |||
| case "id": return Ok(id); | |||
|
Minor comment (on adding SetCorrelation() to the constructor). Other than that looks good to me, |
:)
skofman1
added a commit
that referenced
this pull request
Feb 19, 2016
Propagate correlation id from gallery to search service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.