Send package published notification to package owner(s) when new version is published #2961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion is published Send package published notification to package owner(s) when new version is published
| @@ -1106,6 +1106,11 @@ private ActionResult EditFailed(string id, EditPackageRequest formData, Package | |||
|
|
|||
| // tell Lucene to update index for the new package | |||
| _indexingService.UpdateIndex(); | |||
|
|
|||
| _messageService.SendPackageAddedNotice(package, | |||
There was a problem hiding this comment.
this method is called from the website only. Do we want to send an e-mail in this scenario as well? If the user is here he is already authenticated, so is e-mail necessary?
There was a problem hiding this comment.
Good question. In theory someone could script a form upload as well.
@yishaigalatzer / @csharpfritz thoughts?
There was a problem hiding this comment.
As a security upgrade, I like adding an email notification to all package owners. I'd like to see this enabled by default, but configurable as a preference on my NuGet profile page
There was a problem hiding this comment.
But only for API uploads or also web uploads?
maartenba
added a commit
that referenced
this pull request
Apr 15, 2016
Amends #2961 By popular request, making it possible to unsubscribe from package pushed notifications separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send package published notification to package owner(s) when new version
is published