Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding accept attr for .nupkg upload to guide the user #2963

Merged

Conversation

robertmuehsig
Copy link
Contributor

I noticed that the manual package upload will accept anything and will fail after the postback if the file extension is not a .nupkg:

image

To guide the user to their own luck I added the accept attribute, which will work on most browsers:
http://caniuse.com/#search=accept

This is not a security feature - the security part is already handled on the server - it's just cosmetic. The result (in supported browsers) is this:
image

@yishaigalatzer
Copy link

@robertmuehsig thanks for being awesome!

@maartenba maartenba merged commit e6fe53f into NuGet:master Mar 31, 2016
@maartenba
Copy link
Contributor

This is cool! Thanks @robertmuehsig

@maartenba maartenba mentioned this pull request Mar 31, 2016
10 tasks
@robertmuehsig robertmuehsig deleted the nupkg-upload-file-accept-added branch March 31, 2016 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants