Change routes from packages/<action> to packages/manage/<action> to avoid conflicts with package ids

[scottbommarito]

Currently, if someone creates a package with an id of "upload", "upload-progress", "verify-upload", or "cancel-upload", they can potentially run into conflicts with our routing scheme. In other words, a package with an id of "upload" would be impossible to view through packages/<id>, because MVC would route it to our upload package path route, packages/upload.

To avoid conflicts with our system, this PR changes those routes to packages/manage/upload and so on. Since packages/<id> and packages/manage/<action> are now completely distinct routes, users can upload a package with an id equal to any of our actions and view it without any issues. Note that a package id of "manage" is also still supported.

Will be making some additional PRs in different repos to update the references to the old route URLs.

@maartenba @skofman1 @xavierdecoster

(Fixes #3130)

[dnfclas]

Hi @scottbommarito, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

[maartenba]

Quick Q: what if my package is called "manage"?

[scottbommarito]

@maartenba
Still works! packages/manage does not conflict with packages/manage/<action> so MVC routes it to the package display page. We do have a packages/<id>/<action> route, but all of the actions work as they do for every package, even with "manage".

[maartenba]

Change looks good, did you verify all views as well? (I saw a couple but not 100% sure those are all, perhaps good to make another pass for the paranoid)

[scottbommarito]

Still learning MVC so not entirely sure what you mean by "all views" in this context, but I do know everything in the Views/Packages folder is still reachable and functional.

[scottbommarito]

@maartenba @xavierdecoster @skofman1 @shishirx34 @ryuyu
Looking for some more sign-offs so we can merge this and it doesn't become stale.

[shishirx34]

Looks Good!

[scottbommarito]

@maartenba Can I merge this? You never responded to my response to your question so I wasn't sure whether or not to count it as a "ship-it" haha.

[maartenba]

Good from my side.