Phase 2 of SemVer2 support #3758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavierdecoster
force-pushed
the
feature/semver2
branch
from
eebacb5
to
483e8ba
Compare
xavierdecoster
force-pushed
the
feature/semver2
branch
from
483e8ba
to
4affac8
Compare
ryuyu
reviewed
Apr 21, 2017
| @@ -626,21 +626,6 @@ private static void ValidateNuGetPackageMetadata(PackageMetadata packageMetadata | |||
| { | |||
| throw new EntityException(Strings.NuGetPackagePropertyTooLong, "Id", CoreConstants.MaxPackageIdLength); | |||
| } | |||
| if (packageMetadata.Version.IsPrerelease) | |||
There was a problem hiding this comment.
I think line 551 of this file needs to be moved below where the package dependencies are set (line 599) or the calculation ignores dependencies because it will always act on an empty set.
There was a problem hiding this comment.
Great catch @ryuyu !
There was a problem hiding this comment.
Fixed with bef3dd4
xavierdecoster
force-pushed
the
feature/semver2
branch
from
4affac8
to
bef3dd4
Compare
ryuyu
reviewed
Apr 26, 2017
| @@ -111,6 +135,11 @@ private static Uri BuildLinkForStreamProperty(string routePrefix, string id, str | |||
| return builder.Uri; | |||
| } | |||
|
|
|||
| private static Uri BuildIdLink(string routePrefix, string id, string version, HttpRequestMessage request) | |||
There was a problem hiding this comment.
This method needs to be updated to correctly rebuild and patch the IdLinks for when the request is to a curated feed.
Currently, it will lose this information while patching.
There was a problem hiding this comment.
Good catch! Tracking here: #3861
There was a problem hiding this comment.
PR up for review: #3864
xavierdecoster
force-pushed
the
feature/semver2
branch
5 times, most recently
from
a424d52
to
f9c32c6
Compare
xavierdecoster
force-pushed
the
feature/semver2
branch
6 times, most recently
from
25455f6
to
0de9adc
Compare
xavierdecoster
force-pushed
the
feature/semver2
branch
from
e3110f8
to
08c75ea
Compare
xavierdecoster
force-pushed
the
feature/semver2
branch
from
08c75ea
to
73278d0
Compare
* adding new optional semVerLevel query parameter to v2 odata endpoints * adding new optional semVerLevel query parameter to v2 autocomplete endpoints * Applying semVerLevel filter on v2 OData endpoints * Use [FromUri] attribute on semVerLevel (avoids having single quotes in the parameter value) * Ensure navigation links on v2 feeds use normalized version * Clarifying comment on Get(Id=,Version=) v2 API * Properly default to semver2 inclusion on Get(Id=,Version=) * Compare NormalizedVersion to be able to retrieve matching SemVer2 package versions for a given normalized version string. * Code review feedback * Update and fix broken test data
…ns (#3761) * Keep legacy version compatibility checks in place for non-semver2 versions * Added comment to clarify the reasons behind the legacy version check. * Fix typo * Rename test for clarity * code review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to combine all semver2 related work into a single feature branch PR, part of phase 2 deployment.
Verified in DEV:
Once merged, also merge this: