Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MinClientVersion <= 4.1.0.0 #3860

Merged
merged 2 commits into from
May 8, 2017
Merged

Support MinClientVersion <= 4.1.0.0 #3860

merged 2 commits into from
May 8, 2017

Conversation

maartenba
Copy link
Contributor

@emgarten
Copy link
Member

emgarten commented May 3, 2017

4.1.0 is out already
4.3.0 is available in the CLI preview builds

Why does the gallery limit this? Just to verify the package is sane?

@joelverhagen
Copy link
Member

joelverhagen commented May 3, 2017

Perhaps we should make max exclusive and switch to 5.0.0--. Or just say the major part must be less than or equal to 4. This seems like an overly strict requirement.

@skofman1
Copy link
Contributor

skofman1 commented May 3, 2017

Moved the issue to NuGetGallery repo: #3866

@maartenba maartenba changed the title Support MinClientVersion <= 4.0.0.0 Support MinClientVersion <= 4.1.0.0 May 5, 2017
@maartenba
Copy link
Contributor Author

4.1.0 is out already
4.3.0 is available in the CLI preview builds

Unfortunately, there is no 4.1 of any of the client libraries on NuGet.org?

@skofman1
Copy link
Contributor

skofman1 commented May 8, 2017

@maartenba , why do we need MinClient version check at all? What was the intent on having it as part of the package validation process? I'm trying to understand if we should have an additional issue to remove this validation all together.

@maartenba
Copy link
Contributor Author

maartenba commented May 8, 2017

It has been there since the dark ages AFAIK. Something to tie client release together with supported server version and so on. But meh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants