Fix Focus Visibility #3939
Merged
Fix Focus Visibility #3939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryuyu no idea about past decisions made before I worked on gallery :) |
xavierdecoster
approved these changes
May 11, 2017
| font-size: 1em; | ||
| font-weight: 500; | ||
| padding: 5px; | ||
| .warning.fancy { |
joelverhagen
approved these changes
May 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were setting outline: none in a few places, which caused many elements to not show when they had focus. Set a :focus style globally, and override where necessary.
@xavierdecoster, @skofman1 Is there a reason this was done in these places? I don't want to mess up any explicit decisions we made.
@joelverhagen