Fix InvalidOperationException from profile when multiple version are set to latest #4282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenriksson
requested review from
joelverhagen,
agr,
loic-sharma,
xavierdecoster,
ryuyu,
cristinamanum,
skofman1,
scottbommarito and
shishirx34
scottbommarito
approved these changes
Jun 26, 2017
shishirx34
approved these changes
Jun 26, 2017
joelverhagen
approved these changes
Jun 26, 2017
agr
approved these changes
Jun 26, 2017
| @@ -301,16 +301,18 @@ private void MergeLatestStablePackagesByOwner(User user, bool includeUnlisted, D | |||
|
|
|||
| foreach (var latestStablePackagesById in latestStablePackageVersions.ToList().GroupBy(p => p.PackageRegistration.Id)) | |||
| { | |||
| // Use First() instead of Select() to get the latest package, in case there are multiple latest due to concurrency issue | |||
There was a problem hiding this comment.
You mean Single instead of Select, right?
(below, on line 344, too)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #4281
Note that this selects later version if multiple since order by is descending, whereas DisplayPackage history selects earlier version due to using First with order ascending.
Will file separate bug to fix IsLatest flags with reflow package, as well as trying to make selection of later latest consistent.