Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reflow to update IsLatest state #4318

Merged
merged 1 commit into from
Jul 3, 2017
Merged

Update reflow to update IsLatest state #4318

merged 1 commit into from
Jul 3, 2017

Conversation

chenriksson
Copy link
Member

joelverhagen
joelverhagen approved these changes Jul 3, 2017
View reviewed changes
Copy link
Member

@joelverhagen joelverhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🥇 :shipit:

loic-sharma
loic-sharma approved these changes Jul 3, 2017
View reviewed changes
src/NuGetGallery/Services/PackageService.cs
@@ -815,7 +815,7 @@ private void ValidatePackageTitle(PackageMetadata packageMetadata)
}
}

public async Task UpdateIsLatestAsync(PackageRegistration packageRegistration, bool commitChanges = true)
public virtual async Task UpdateIsLatestAsync(PackageRegistration packageRegistration, bool commitChanges = true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the virtual needed here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for the mock.

@chenriksson chenriksson merged commit 192adc1 into dev Jul 3, 2017
@chenriksson chenriksson deleted the chenriks-reflow branch July 5, 2017 15:55
@joelverhagen joelverhagen mentioned this pull request Jul 6, 2017
Merged
@skofman1 skofman1 mentioned this pull request Jul 7, 2017
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelverhagen joelverhagen joelverhagen approved these changes

@loic-sharma loic-sharma loic-sharma approved these changes

@ryuyu ryuyu Awaiting requested review from ryuyu

@skofman1 skofman1 Awaiting requested review from skofman1

@scottbommarito scottbommarito Awaiting requested review from scottbommarito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenriksson @joelverhagen @loic-sharma @dnfclas