Support username casing change in Admin UI

src/NuGetGallery/Areas/Admin/Controllers/ChangeUsernameController.cs

@@ -123,32 +123,37 @@ public async Task<ActionResult> ChangeUsername(string oldUsername, string newUse
                 return Json(HttpStatusCode.BadRequest, "New username validation failed.", JsonRequestBehavior.AllowGet);
             }
 
-            var newAccountForOldUsername = new User()
+            if (account.Username.Equals(newUsername, StringComparison.OrdinalIgnoreCase) == false)
             {
-                Username = account.Username,
-                EmailAllowed = false,
-                IsDeleted = true,
-                CreatedUtc = _dateTimeProvider.UtcNow
-            };
+                // We're doing a full username change and not just a casing change so we need to lock the old username
+                var newAccountForOldUsername = new User()
+                {
+                    Username = account.Username,
+                    EmailAllowed = false,
+                    IsDeleted = true,
+                    CreatedUtc = _dateTimeProvider.UtcNow
+                };
+
+                _userRepository.InsertOnCommit(newAccountForOldUsername);
+            }
 
             account.Username = newUsername;
 
             await _auditingService.SaveAuditRecordAsync(new UserAuditRecord(account, AuditedUserAction.ChangeUsername));
-
-            _userRepository.InsertOnCommit(newAccountForOldUsername);
-
             await _entitiesContext.SaveChangesAsync();
 
             return Json(HttpStatusCode.OK, "Account renamed successfully!", JsonRequestBehavior.AllowGet);
         }
 
         private ValidateUsernameResult ValidateUsername(string username)
         {
-            var result = new ValidateUsernameResult();
-            result.IsFormatValid = UsernameValidationRegex.IsMatch(username);
-            result.IsAvailable = _userService.FindByUsername(username, includeDeleted: true) == null;
+            var foundUser = _userService.FindByUsername(username, includeDeleted: true);
 
-            return result;
+            return new ValidateUsernameResult()
+            {
+                IsFormatValid = UsernameValidationRegex.IsMatch(username),
+                IsAvailable = foundUser == null || foundUser.Username != username // The username check is in the event where we found a user in the DB but we're doing a cAsIng change
+            };
         }
     }
 }