-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nuget 5.5.0 release notes #1963
Conversation
Docs Build status updates of commit 79a38d0: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
Docs Build status updates of commit dd41523: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
Docs Build status updates of commit a3aab5e: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like the summary and issue list could use some more work. I get the impression that #1799, for example, actually removed things that aren't interesting to users and simply linked to the entire list for anything not listed. (you can link to the ZenHub release here: https://app.zenhub.com/workspaces/nuget-client-team-55aec9a240305cf007585881/reports/release?release=5e0e5fbd021f7aa0ec95db18)
I'm a little bothered by that None:
section and can only assume it was due to issues not being properly tagged, so you might have to sort through and move them into bug/feature/dcr accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand you didn't title these issues etc, but I think we need to rework the release notes quite a bit.
The release notes should contain relevant information, not everything that we do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a title change
Docs Build status updates of commit af5399d: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
Docs Build status updates of commit 2bb316b: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
@zkat - I have cleaned up None section as much as possible. I think I need your help to categories the current issues in None section because I don't find appropriate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better.
Is it the tool that's missing a few scenarios?
I've commented on a few things here or there, we should validate the tool is doing the right thing.
Co-Authored-By: Fernando Aguilar <[email protected]>
Docs Build status updates of commit f3e2d47: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More comments
Docs Build status updates of commit f3e2d47: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
Docs Build status updates of commit 2502102: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
Docs Build status updates of commit 48e0fbc: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
@zkat, @aortiz-msft, @rrelyea - the link to the List of all issues fixed in this release - 5.5 requires a GitHub login and makes users accept ZenHub privacy statements and such. In all the user goes through 3 - 4 screens and 10s of clicks before they can see something. Is this expected? |
Co-Authored-By: Karan Nandwani <[email protected]>
Docs Build status updates of commit 8a0bf31: 🕙 Pending: waiting for processors (14 builds ahead of you) |
Docs Build status updates of commit 8a0bf31: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just unblocking on my end...looks better.
Co-Authored-By: Karan Nandwani <[email protected]>
Docs Build status updates of commit f82f8e6: 🕙 Pending: waiting for processors (39 builds ahead of you) |
Docs Build status updates of commit f82f8e6: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
|
||
* Support `packages.config` with msbuild /restore - [#8506](https://github.com/NuGet/Home/issues/8506) | ||
|
||
### Issues fixed in this release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this section should be separate from the "Summary: What's New in 5.5". As such, this title should be brought at the same level. (I.e. Use ## instead of ###.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my recommendation would be to keep formatting consistent with past release 5.x release notes at-least. I believe the current PR is consistent. If we decide to make a change, we should change it in other 5.x rel notes as well.
Co-Authored-By: aortiz-msft <[email protected]>
Docs Build status updates of commit 89ed4db: ✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
Automated draft of release notes.
Thanks @zkat for your help in tweaking metadata and generating draft release notes.
Please check to make sure all the work that shipped in 5.5 is covered here and the titles are appropriate. If we tweak the issue titles manually in this md file, we should also modify the real issue title.
I have manually deleted few issues from the autogenerated release notes draft, only if the issues are part of CPVM feature, XPlat signing feature and duplicates. Please refer to this change log to know more the issues deleted manually and let me know your feedback.