Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MSBuildSdk as well known package type #2843

Closed
wants to merge 2 commits into from
Closed

Add MSBuildSdk as well known package type #2843

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2627e8
Add MSBuildSdk as well known package type
kant2002 Aug 7, 2022
60b621f
Fix link
kant2002 Aug 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/create-packages/set-package-type.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ Packages can be marked with one more more *package types* to indicate its intend

- `Template` type packages provide [custom templates](/dotnet/core/tools/custom-templates) that can be used to create files or projects like an app, service, tool, or class library.

- `MSBuildSdk` type packages provides [MSBuild SDK](/visualstudio/msbuild/how-to-use-project-sdk) that can be used to augment behaviour of projects. Examples of such SDK can be found on [following GitHub repo](https://github.com/microsoft/MSBuildSdks).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure how I feel about this change, as while it's commonly understood what the MSBuildSDK package is, NuGet/Home#6484 is still not resolved, so if you ask the client, this isn't really known.

It's probably cheap to fix, but I just haven't had the time.

@jeffkl thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick bump for @jeffkl so we can revise or merge.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its probably fine to document it and implement it later honestly. There's no enforcement as far as I know so you can put any value in there you want. At least if we document it then packages could be correct.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm comfortable with whatever you 2 decide. Don't block merging/changes on me :)


Packages not marked with a type, including all packages created with earlier versions of NuGet, default to the `Dependency` type.

> [!NOTE]
Expand Down