Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document MSBuildSdk package type #3036

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Document MSBuildSdk package type #3036

merged 1 commit into from
Jun 6, 2023

Conversation

robmen
Copy link
Contributor

@robmen robmen commented Mar 30, 2023

No description provided.

@robmen robmen requested review from a team as code owners March 30, 2023 09:43
@learn-build-service-prod
Copy link

Learn Build status updates of commit 1c3999a:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/create-packages/set-package-type.md ⚠️Warning View Details

docs/create-packages/set-package-type.md

  • Line 20, Column 34: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/visualstudio/msbuild/how-to-use-project-sdk' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 20, Column 34: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/visualstudio/msbuild/how-to-use-project-sdk' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit 0f9d7ef:

✅ Validation status: passed

File Status Preview URL Details
docs/create-packages/set-package-type.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@robmen
Copy link
Contributor Author

robmen commented Mar 30, 2023

Feel free to edit this PR as appropriate. I was just made aware of this package type, and figured others would benefit from knowing about it as well.

@nkolev92
Copy link
Member

#2843 is an older with the same goal.

cc @jeffkl

Copy link
Contributor

@erdembayar erdembayar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't see there is other pending PR comment.

@erdembayar erdembayar self-requested a review April 4, 2023 22:54
Copy link
Contributor

@JonDouglas JonDouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@JonDouglas JonDouglas merged commit 98068a7 into NuGet:main Jun 6, 2023
nkolev92 pushed a commit that referenced this pull request Jun 14, 2023
* Updated Finding-and-Choosing-Packages.md (#3042)

* Add security audit concept doc (#3060)

* Add security audit concept doc

* Update docs/concepts/Auditing-Packages.md

Co-authored-by: Andy Zivkovic <[email protected]>

* Fix editing section

* Update Auditing-Packages.md

* Add h1

* Update Auditing-Packages.md

* Update docs/concepts/Auditing-Packages.md

Co-authored-by: Andy Zivkovic <[email protected]>

* Update Auditing-Packages.md

---------

Co-authored-by: Andy Zivkovic <[email protected]>

* Update NuGet-FAQ.yml (#3066)

Add Q# as supported language

* Add the Native Target Framework (#3067)

In the Blog Post (https://devblogs.microsoft.com/nuget/native-support/#native-target-framework) it is precisely stated that you should specify the "native" target framework, when developing win32 applications

* Document MSBuildSdk package type (#3036)

* Update readme page doc (#3025)

* update allowlist + additional markdown feature support

* reword

---------

Co-authored-by: Lynn Dai <[email protected]>

* NuGet June 2023 servicing release udpates (#3072)

---------

Co-authored-by: Rishi Joshi <[email protected]>
Co-authored-by: Andy Zivkovic <[email protected]>
Co-authored-by: Bradben <[email protected]>
Co-authored-by: bub1ick <[email protected]>
Co-authored-by: Rob Mensching <[email protected]>
Co-authored-by: lyndaidaii <[email protected]>
Co-authored-by: Lynn Dai <[email protected]>
Co-authored-by: Heng Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants