Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better monorepo support. Use @embroider/addon-blueprint #37

Merged
merged 5 commits into from
Jan 5, 2023

Conversation

NullVoxPopuli
Copy link
Owner

@NullVoxPopuli NullVoxPopuli commented Aug 25, 2022

tl;dr: this becomes a serious project 🙃

Lots of quality-of-life improvements in here, but some tradeoffs that will be less trade-offy as upstream things get resolved.

Support for npm, yarn, and pnpm workspaces, given: embroider-build/addon-blueprint#36

JS Support

  • js support is now much better, because I'm using the v2 addon blueprint (with all the flags that have been added for configuring package paths), and modifying the output of that (whereas previously I was building a v2 addon manually)

TS Support

TODO:

  • Support Phased migration
    • Phase 1: move the tests to their own app
    • Phase 2: convert the addon to v2
  • Support downgrading dependencies from the v2 blueprint (rollup-plugin-ts @v2) -- maybe

@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2023

🦋 Changeset detected

Latest commit: a7e148b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@NullVoxPopuli
Copy link
Owner Author

Gonna merge since this PR has gotten ridiculous, C.I., and the aforementioned features can be developed in PRs that are actually easy to review.

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review January 5, 2023 00:30
@NullVoxPopuli NullVoxPopuli merged commit 95c74a4 into main Jan 5, 2023
@NullVoxPopuli NullVoxPopuli deleted the monorepo-support branch January 5, 2023 00:30
@github-actions github-actions bot mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant