Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keepLatest types #1019

Merged
merged 4 commits into from
Oct 20, 2023
Merged

Conversation

wagenet
Copy link
Contributor

@wagenet wagenet commented Oct 19, 2023

The undefined was unnecessary.

@stackblitz
Copy link

stackblitz bot commented Oct 19, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2023

🦋 Changeset detected

Latest commit: 11c4d62

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ember-resources Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wagenet wagenet marked this pull request as ready for review October 19, 2023 18:15
@wagenet
Copy link
Contributor Author

wagenet commented Oct 19, 2023

The lint failure seems to be present in develop.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the type tests!

@NullVoxPopuli NullVoxPopuli merged commit 636e9ea into NullVoxPopuli:main Oct 20, 2023
25 of 27 checks passed
@github-actions github-actions bot mentioned this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants