-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infra modernization, support both built in types from ember-source, as well as the types from DefinitelyTyped #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
NullVoxPopuli
force-pushed
the
modernized-build
branch
from
January 10, 2024 00:21
2ab8165
to
cc96cd6
Compare
Estimated impact to a consuming app, depending on which bundle is imported
|
Preview URLsreadme: https://e5fb74d0.ember-resources.pages.dev |
NullVoxPopuli
force-pushed
the
modernized-build
branch
from
January 10, 2024 17:17
5c1b02e
to
4de9460
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… dependency isolation
NullVoxPopuli
force-pushed
the
modernized-build
branch
from
January 10, 2024 22:35
e1ad252
to
8303c7f
Compare
ugh Re-roll lockfile lint:fix
NullVoxPopuli
force-pushed
the
modernized-build
branch
from
January 10, 2024 22:36
8303c7f
to
9607457
Compare
… respect dependency isolation" This reverts commit d11bb79.
NullVoxPopuli
changed the title
Modernization, use simpler babel transform, emit declarations to separate directory
Infra modernization, support both built in types from ember-source, as well as the types from DefinitelyTyped
Jan 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be non-breaking for consumers.
Diff is bonkers because this change moves from a single (traditional) lockfile to multiple lockfiles to enforce more isolation between workspaces.