Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fixer for TS#56571 to remove all References #8

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

NullVoxPopuli
Copy link
Owner

microsoft/TypeScript#56571 (comment)

I'm increasingly starting to believe /// <reference is not the correct approach.

You

  • move types to dependencies
  • or declare a peerDependencies entry on the types
    and your consumer provides the types (this is the Scenario the TS team has been hesitant to support)

@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Feb 9, 2024
@NullVoxPopuli NullVoxPopuli merged commit 56c1b08 into main Feb 9, 2024
5 checks passed
@NullVoxPopuli NullVoxPopuli deleted the remove-every-reference-by-default branch February 9, 2024 05:40
@github-actions github-actions bot mentioned this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant