-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema updates for 3.0.4 #4125
Comments
There are definitely improvements to be made to the 3.0 schemas, but there aren't any schema-impacting differences between 3.0.3 and 3.0.4. The only version-ish thing that should change is the date in the AFAIK, this is true across 3.0.0 - 3.0.4, and any schema applying to one applies to all and should only mention 3.0 in comments or other text (no patch release number). Some might make an argument regarding Schemas can be viewed on the spec site. I didn't think to comment on it in the 3.1 schema issue, but I'm pretty certain the spec should just link to this page and not to anything specific. (For those not familiar with the history of "latest" schemas, we should not have a "latest" schema symlink because refining the constraints to be more accurate could cause automated systems to suddenly invalidate previously-valid OADs which is not a nice thing to do – we tried this several ways with the JSON Schema meta-schemas before deciding on the date-based |
Note that the PR coming from this issue will be a blocker for 3.0.4. I have some of the more trivial fixes completed already, so please poke me if I should PR those now. |
@karenetheridge how will it be a blocker? Logically, I agree that we should have the schemas done for the release, but we never have in the past and the current 3.0 schemas won't be any worse for 3.0.4 than they are for 3.0.3. So what would break so badly that we should consider it a blocker? (If you want to argue that we should publish the schema fixes simultaneously with the patch release just on general principle, I'd support that, but I've never been successful with that argument here in the past). |
I see; I wasn't aware of that.
Yes, it was my assumption that this was the case. Otherwise how can tooling vendors proceed with adding support for the new release? |
The 3.0.4 schemas need a review pass for accuracy.
$comment
,description
and$id
URIs for v3.0.3->v3.0.4 (where can an html preview of the specification be viewed?)(I am converting locally to draft7 so as to allow:
apt-get libjson-schema-modern-perl; json-schema-eval --strict --validate-schema schemas/v3.0/schema.json
)The text was updated successfully, but these errors were encountered: