-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-pages: no download link for "latest" schema #4133
Conversation
@ralfhandl I'm a bit confused as the preview still has lots of "latest" links that go to |
Updated the PR description:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ralfhandl thanks- I'm approving this because it does what it says it does, and that's definitely an improvement! :-)
I do ask why we're using a "latest" link even for the HTML pages rather than just using the latest date as that link. I feel like having a "latest" HTML link will encourage people to look for a "latest" schema, while a design like:
- view latest schema: 2022-10-07
would set the users' expectations more accurately through the use of a date as the link name plus a filename of schema/2022-10-07.html
(or whatever is appropriate for including the date). But if there's interest in discussing this further, we can do that in another issue if you'd like.
@handrews: removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ralfhandl !
This comment suggests that
The wrapper markdown page for the "view" links now has the same name as the schema file it wraps and the
latest
symlinks have been removed.Note
The new publishing process MUST rename the wrapper markdown pages for date-named schema files to match the most recent schema file.
Now:
With this PR:
Preview: https://ralfhandl.github.io/OpenAPI-Specification/