Clarified supported Ecma edition for regex #1725
Conversation
Added supported Ecma edition (5.1) for regular expressions in the link text and used the formal name: [Ecma-262 Edition 5.1](https://www.ecma-international.org/ecma-262/5.1/). See also: #1687
versions/3.0.3.md
Outdated
| @@ -2284,7 +2284,7 @@ The following properties are taken directly from the JSON Schema definition and | |||
| - exclusiveMinimum | |||
| - maxLength | |||
| - minLength | |||
| - pattern (This string SHOULD be a valid regular expression, according to the [ECMA 262 regular expression](https://www.ecma-international.org/ecma-262/5.1/#sec-7.8.5) dialect) | |||
| - pattern (This string SHOULD be a valid regular expression, according to the [Ecma-262 Edition 5.1 regular expression](https://www.ecma-international.org/ecma-262/5.1/#sec-7.8.5) dialect) | |||
There was a problem hiding this comment.
Hm, not sure... https://www.ecma-international.org/ecma-262/5.1/#sec-7.8.5 says:
This is the HTML rendering of Ecma-262 Edition 5.1, The ECMAScript Language Specification.
It looks like ECMA is uppercase mostly when used in 'ECMAScript'.
There was a problem hiding this comment.
Wow, what a mess of mixed caps! :)
You're right though, based on their usage in that doc, we can basically do what we want. My own personal sensibilities would argue for capitalization, and the header on that page does use capitalization:
... but then does something else shortly thereafter. My point is definitely a nit, and this shouldn't hold up the acceptance, though if you don't mind using ECMA instead, please do, thx.
| @@ -2299,7 +2299,7 @@ The following properties are taken directly from the JSON Schema definition and | |||
| - exclusiveMinimum | |||
| - maxLength | |||
| - minLength | |||
| - pattern (This string SHOULD be a valid regular expression, according to the [ECMA 262 regular expression](https://www.ecma-international.org/ecma-262/5.1/#sec-15.10.1) dialect) | |||
| - pattern (This string SHOULD be a valid regular expression, according to the [Ecma-262 Edition 5.1 regular expression](https://www.ecma-international.org/ecma-262/5.1/#sec-15.10.1) dialect) | |||
There was a problem hiding this comment.
Conflict with link fragment change resolved here. Now LGTM.
There was a problem hiding this comment.
Thanks Mike. I discussed with @webron , too, and ready to merge.
Added supported Ecma edition (5.1) for regular expressions in the link text and used the formal name: Ecma-262 Edition 5.1.
See also: #1687