Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide example of where this project is talking about #2299

Closed
wants to merge 1 commit into from

Conversation

fulldecent
Copy link

An example is worth a 1000-word README.

Copy link
Member

@MikeRalphson MikeRalphson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Review comments inline.

@@ -15,6 +15,10 @@ The OpenAPI Specification does not require rewriting existing APIs. It does not

This GitHub project is the starting point for OpenAPI. Here you will find the information you need about the OpenAPI Specification, simple examples of what it looks like, and some general information regarding the project.

Here is an example API description file following the OpenAPI Specification: https://petstore.swagger.io/v2/swagger.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we have examples within the repo, I think it would be a mistake to link outside to one particular vendor's example.

@@ -15,6 +15,10 @@ The OpenAPI Specification does not require rewriting existing APIs. It does not

This GitHub project is the starting point for OpenAPI. Here you will find the information you need about the OpenAPI Specification, simple examples of what it looks like, and some general information regarding the project.

Here is an example API description file following the OpenAPI Specification: https://petstore.swagger.io/v2/swagger.json

And here is an API documentation website rendered automatically from that file: https://petstore.swagger.io
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of the range of open-source and commercial solutions providing documentation renderers (as well as this only being one use-case for an OpenAPI document), I think it would be better to remove this entirely.

@MikeRalphson
Copy link
Member

Closing due to inactivity - but please feel free to reopen the PR if necessary. With the changes requested, this PR would be verging on the empty anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants